Avoid insertion of spurious applies when inlining #2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case crashed before, because it encountered a selection with an inserted apply, which should be typed but was not. The fix prevents inserting the apply by overriding the usual behavior in ReTyper.
odersky
force-pushed
the
fix-inline-apply
branch
from
088d9ff to
53e35e0
Compare
liufengyun
reviewed
Aug 22, 2017
| val res = super.typedSelect(tree, pt) | ||
| assert(tree.hasType, tree) | ||
| val qual1 = typed(tree.qualifier, selectionProto(tree.name, pt, this)) | ||
| val res = untpd.cpy.Select(tree)(qual1, tree.name).withType(tree.typeOpt) |
There was a problem hiding this comment.
I'm wondering why use AnySelectionProto instead of using selectionProto(tree.name, pt, this) as expected type in Retyper.typedSelect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case crashed before, because it encountered
a selection with an inserted apply, which should be typed
but was not. The fix prevents inserting the apply.